Fix for #848 (not_constant fails within groups with 1 element) #849
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
dbeatty10
requested changes
Aug 7, 2024
There was a problem hiding this comment.
@igor-lobanov-maersk many apologies for the delayed review here!
Could you add a test case for the scenario that your PR is fixing? That way we can confirm it fails without your fix but succeeds afterwards.
Here's an example:
dbt-utils/integration_tests/models/generic_tests/schema.yml
Lines 4 to 10 in 9237ba9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #848
This is a:
All pull requests from community contributors should target the
mainbranch (default).Description & motivation
As described in the bug report for #848, not_constant generic test fails when grouping is used and one of the groups has only one element. The implementation considers the value of this one element constant and fails the test. Whilst such interpretation is technically correct, the context where such test is used a different interpretation arguably would be preferable. I provided additional details in the bug report.
Checklist
star()source) N/Alimit_zero()macro in place of the literal string:limit 0N/Adbt.type_*macros instead of explicit datatypes (e.g.dbt.type_timestamp()instead ofTIMESTAMPN/AI did not add a test, because it's not clear to me how such tests are written. There is no prior test for not_constant macro to extend. That said, I'm happy to write one with some guidance from the core team.